-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import database #2964
Import database #2964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also open an issue about removing ImportDB operator and instead reuse StandaloneCall operator and we make importDB as a pragma function
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2964 +/- ##
==========================================
+ Coverage 93.50% 93.52% +0.02%
==========================================
Files 1121 1125 +4
Lines 42950 43081 +131
==========================================
+ Hits 40161 40293 +132
+ Misses 2789 2788 -1 ☔ View full report in Codecov by Sentry. |
This PR is to add support for importing databases. We joint queries based on the
schema.cypher
,copy.cypher
andmacro.cypher
(files created by export database), getting the query like"create node table xxx; create rel table xxx;copy from xxxx;"
. Then we execute the generated multiple query statements. Currently, due to we do not support DDL and copy statements in one transaction, each single query statement in generated multiple query statement has its own auto transaction. This should be refactored after we support DDL and Copy statements in one transaction.