Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a few things to get rust crates working properly:
cargo package
ignores untracked files in git repositories, which would pull in things like build files, so I added a fileinclude
list to make sure only the necessary source files are included in the crate.OUT_DIR
environment variable, so it should really be an out of source build. As such, I set it up to run the arrow and kuzu cmake builds manually within build.rs instead of running them through the Makefile.Additionally: