Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spill to disk setting doc #280

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add spill to disk setting doc #280

merged 1 commit into from
Nov 11, 2024

Conversation

benjaminwinger
Copy link
Collaborator

No description provided.

Copy link
Member

@prrao87 prrao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will hold off on merging till this is available in the next release.

@prrao87 prrao87 added next-release Include for next release hold-till-release Hold off on merging till the release is finished labels Oct 3, 2024
@benjaminwinger
Copy link
Collaborator Author

Right, sorry, should this have gone into the dev branch instead, or is that for something else?

@prrao87
Copy link
Member

prrao87 commented Oct 3, 2024

No, I added the required labels to this and will ensure it goes to the live branch once we release. Thanks!

@ray6080
Copy link
Contributor

ray6080 commented Nov 5, 2024

Besides adding doc to the configuration part, should we also mention that spilling to disk is supported somewhere in the "Import data" section?

@benjaminwinger
Copy link
Collaborator Author

I've added a section in the import docs explaining the feature, and also added documentation for when spill to disk is disabled by default, and how it can be disabled manually.

Copy link
Member

@prrao87 prrao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will hold off on merging this till the release.

@ray6080 ray6080 changed the base branch from main to dev November 11, 2024 06:12
@ray6080 ray6080 merged commit 490f21f into dev Nov 11, 2024
2 checks passed
@ray6080 ray6080 deleted the spill-to-disk-docs branch November 11, 2024 06:21
@ray6080 ray6080 removed next-release Include for next release hold-till-release Hold off on merging till the release is finished labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants