-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spill to disk setting doc #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - will hold off on merging till this is available in the next release.
Right, sorry, should this have gone into the dev branch instead, or is that for something else? |
No, I added the required labels to this and will ensure it goes to the live branch once we release. Thanks! |
Besides adding doc to the configuration part, should we also mention that spilling to disk is supported somewhere in the "Import data" section? |
75750f1
to
939e6b8
Compare
I've added a section in the import docs explaining the feature, and also added documentation for when spill to disk is disabled by default, and how it can be disabled manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will hold off on merging this till the release.
939e6b8
to
8cd0ea5
Compare
No description provided.