fix: permission issue

[mazzy89]

This is an attempt to fix permission issue running a rootless container which is anyway always a good practice in the industry.

I have tested and it works. permissions inside the docker container for the pulled repo are now correct and at the next checkout no other issues are present.

Close #48

[mazzy89]

Hey @highb please can you take a look to this PR?

[mazzy89]

I will switch this once the PR is reviewed and approved.

[highb]

Hey @mazzy89 , thanks for the contribution! I'll take a look today.

[highb]

Ah, I remember why I didn't set a USER. GitHub's documentation explicitly says you shouldn't set one:

Docker actions must be run by the default Docker user (root). Do not use the USER instruction in your Dockerfile, because you won't be able to access the GITHUB_WORKSPACE directory.

But if you're finding different behavior in your testing, perhaps it might work.

[mazzy89]

Thanks @highb

I didn't know that limitation. I have implemented and I have personally tested and this branch is currently running on my side and it worked without issues.

[mazzy89]

@highb testing jobs are failing for permission issues. I will check. Build job is failing for something else I guess.

[mazzy89]

The testing job fails with error

/action-promote/entrypoint.sh: line 23: /github/file_commands/set_env_beb44ca8-e410-464a-8194-7ab590e9e158: Permission denied

It seems it cannot setup GITHUB_ENV. The user kustomize-everything created in the Dockerfile misses permissions. On my side I do not experience this issue. I run on a self-hosted runner though.

[mazzy89]

Unfortunately we are experiencing the typical issue "it works on my computer". The issue is extensively documented here actions/runner#2411. It works for me because the user in the runner maps the one created in the Docker container (by coincidence). I need to sit and think about how we could solve this issue. Open to any suggestions.

[highb]

Unfortunately we are experiencing the typical issue "it works on my computer". The issue is extensively documented here actions/runner#2411. It works for me because the user in the runner maps the one created in the Docker container (by coincidence). I need to sit and think about how we could solve this issue. Open to any suggestions.

A classic issue, for sure. As for ideas, I'll also have to think this over for a while and see if I come up with anything.

[highb]

@mazzy89 Sorry for the radio silence, there. Are you still interested in getting this PR in? Did you verify the newer changes you've made against your code base to see if it fixes the problem? I'm trying out the changes on my own branch.

[highb]

Looking at the actions runs, it looks like there are still some permissions issues on the Dockerfile build.