Annofabのパーソナルアクセストークンに対応しました #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuji38kwmt
commented
Oct 5, 2024
| empty-docstring, | ||
| too-many-positional-arguments, # コマンドに対応するメソッドでは引数の数が多くなるため |
There was a problem hiding this comment.
Pylint 3.3で追加されたルールを無視する
https://pylint.pycqa.org/en/stable/whatsnew/3/3.3/index.html#new-checks
yuji38kwmt
commented
Oct 5, 2024
| return | ||
| assert annofab_id is not None and annofab_pass is not None |
There was a problem hiding this comment.
assert文がなくてもmypy 1.11.2 は通ったので、assert文を削除しました。
There was a problem hiding this comment.
そりゃまぁ、ClientLoaderのコンストラクタの型変わってますからね
seraphr
reviewed
Oct 5, 2024
yuji38kwmt
commented
Oct 8, 2024
Comment on lines
-51
to
-52
| env_annofab_user_id = os.environ.get("ANNOFAB_USER_ID") | ||
| env_annofab_password = os.environ.get("ANNOFAB_PASSWORD") |
There was a problem hiding this comment.
グローバルな場所で環境変数を読み込むと、テストがやりにくかったので、get_annofab_credential内で環境変数を読み込むようにしました。
seraphr
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #148
対応内容
ANNOFAB_PATまたは--annofab_patでトークンを指定できるようにしました。確認したこと
project set_whole_annotation_areaコマンドで以下の動作を確認しました。--annofab_patでトークンを指定できることANNOFAB_PATの値が読み込まれること補足
--annofab_id,--annofab_passの名前をannofab-cliに合わせる #145 を対応してから、対応する予定です。