fix: use ISO 8601 year number #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parithosh
approved these changes
Jan 2, 2025
This reverts commit 7007fb4.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](1.4.3...2.0.0) (2025-01-02) ### ⚠ BREAKING CHANGES * impl dependency list flag ([#2543](#2543)) ### Features * impl dependency list flag ([#2543](#2543)) ([a6c1113](a6c1113)) ### Bug Fixes * use ISO 8601 year number ([#2621](#2621)) ([97324e8](97324e8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Vector logs aggregator output
%Yspecifier for year which is the proleptic Gregorian year instead of%Gspecifier the ISO 8601. Logs are read with the ISO format so this created a mismatch in logs being read / written at the end of 2024 (eg.Youtput the year 2024 on Dec. 30th 2024 whereas the ISO 8601 year on that date is 2025)Is this change user facing?
NO