fix: emui yaml editor populating with values #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Jan 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.19](0.86.18...0.86.19) (2024-02-09) ### Features * build nix image ([#2132](#2132)) ([0eae9fc](0eae9fc)) * enclave builder tweaks ([#2142](#2142)) ([aaf64ca](aaf64ca)) * enforce enclave builder validation ([#2144](#2144)) ([5dcdd9e](5dcdd9e)) ### Bug Fixes * emui yaml editor populating with values ([#2079](#2079)) ([9bd26a8](9bd26a8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
@mieubrisse performed the following:
{})This is unexpected as the user has not specified values for these args. This PR fixes an issue specifically in boolean input that caused this problem - when we convert from 'kurtosis args' to 'form args' (YAML -> Form) we set the value for the boolean input to
""(rather than undefined - I don't think we can set values on the form to the undefined value). Then when we convert 'form args' to 'kurtosis args' (Form -> YAML) we need to treat the empty string as if no value were set, rather than a falsey value.Is this change user facing?
YES
References (if applicable):