chore: only run build_enclave_manager_webapp on non docs changes and tagged commits
#2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Jan 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ribe (#2047) ## Description: This fixes the issue seen in https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/10677/workflows/66565433-39e0-4397-b0d8-4c3c81ad366b/jobs/152621. When ci checks out code in a step it doesn't fetch tags, so `git describe --exact-match` will always fail - this change fixes this by fetching tags. ## Is this change user facing? NO ## References (if applicable): - https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/10677/workflows/66565433-39e0-4397-b0d8-4c3c81ad366b/jobs/152621 -#2041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Yesterday we removed the logic which skips
build_enclave_manager_webappif the build commit diff againstmainhas only docs changes. We did this because we wantbuild_enclave_manager_webappto run onmainduring publish - so that commit would always have no diff frommain(as it would be the same commit.This change means that we skip
build_enclave_manager_webapponly if the current commit is not tagged and the diff against main has no changes other than docs changes.This restores the previous behaviour, with the exception that
build_enclave_manager_webappruns on tagged commits - ie it can run during publish jobs.Is this change user facing?
NO
References (if applicable):