fix: refactor the emui components to the shared package #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
h4ck3rk3y
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description: This PR refactors the `components` from the emui into the new `kurtosis-ui-components` package, additionally it makes use of `kurtosis-package-indexer-sdk` from kurtosis-tech/kurtosis-package-indexer#81 for the package indexer types (types are used by the shared components, and the actual client definition is used by the app). ## Is this change user facing? NO ## References (if applicable): * https://www.notion.so/kurtosistech/2023-12-December-Frontend-Burndown-ad4ea71b05d843fe8efc97c2e61607b7
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.49](0.85.48...0.85.49) (2023-12-18) ### Features * add production mode to k8s ([#1963](#1963)) ([b0e27e6](b0e27e6)) * persistent volumes work on multi node k8s clusters ([#1943](#1943)) ([b2fd9f2](b2fd9f2)) * User service K8S ingresses for reverse proxy routing ([#1941](#1941)) ([c37dd7f](c37dd7f)) ### Bug Fixes * adding remove logs aggregator container function when it already exists ([#1974](#1974)) ([5d74d16](5d74d16)) * Do not fail if the Traefik config dir path already exists ([#1966](#1966)) ([4e6f7d7](4e6f7d7)) * ignore the current status of the service during a start/stop ([#1965](#1965)) ([1c4863f](1c4863f)) * refactor the emui components to the shared package ([#1959](#1959)) ([a406973](a406973)) * Set the user service K8S ingress labels so it can be found ([#1962](#1962)) ([9cc5f77](9cc5f77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]> Co-authored-by: leoporoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the
componentsfrom the emui into the newkurtosis-ui-componentspackage, additionally it makes use ofkurtosis-package-indexer-sdkfrom kurtosis-tech/kurtosis-package-indexer#81 for the package indexer types (types are used by the shared components, and the actual client definition is used by the app).Is this change user facing?
NO
References (if applicable):