feat: Add cli argument to control image download #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
reviewed
Oct 6, 2023
api/golang/core/lib/binding_constructors/binding_constructors.go
Outdated
Show resolved
Hide resolved
tedim52
reviewed
Oct 16, 2023
container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go
Outdated
Show resolved
Hide resolved
tedim52
reviewed
Oct 16, 2023
.../server/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
Outdated
Show resolved
Hide resolved
|
lostbean
force-pushed
the
edgar/image-download-flag
branch
from
cd42a9f to
24124f2
Compare
Deploying with
|
| Latest commit: |
70d5ce7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://246957bb.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://edgar-image-download-flag.kurtosis-docs.pages.dev |
@leeederek the issue is already assigned to me and I just updated the documentation to include the new flag. |
tedim52
reviewed
Oct 20, 2023
tedim52
reviewed
Oct 20, 2023
container-engine-lib/lib/backend_impls/docker/docker_manager/create_and_start_container_args.go
Outdated
Show resolved
Hide resolved
tedim52
reviewed
Oct 20, 2023
tedim52
reviewed
Oct 20, 2023
tedim52
reviewed
Oct 20, 2023
.../server/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
Outdated
Show resolved
Hide resolved
tedim52
reviewed
Oct 20, 2023
.../server/api_container/server/startosis_engine/startosis_validator/docker_images_validator.go
Outdated
Show resolved
Hide resolved
tedim52
reviewed
Oct 20, 2023
core/server/api_container/server/startosis_engine/startosis_validator/validator_environment.go
Outdated
Show resolved
Hide resolved
tedim52
reviewed
Oct 20, 2023
container-engine-lib/lib/backend_interface/objects/image_download_mode/image_download_mode.go
Show resolved
Hide resolved
tedim52
reviewed
Oct 20, 2023
core/server/api_container/server/startosis_engine/startosis_validator.go
Outdated
Show resolved
Hide resolved
tedim52
requested changes
Oct 20, 2023
tedim52
reviewed
Oct 23, 2023
tedim52
reviewed
Oct 23, 2023
tedim52
approved these changes
Oct 23, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.0](0.84.13...0.85.0) (2023-10-30) ### ⚠ BREAKING CHANGES * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ### Features * Add cli argument to control image download ([#1495](#1495)) ([f210a76](f210a76)) ### Bug Fixes * run_sh doesn't remove new lines from input ([#1642](#1642)) ([a969dff](a969dff)) ### Code Refactoring * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ([e7ab58a](e7ab58a)), closes [#843](#843) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]> Co-authored-by: leoporoli <[email protected]>
h4ck3rk3y
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.0](0.84.13...0.85.0) (2023-10-30) ### ⚠ BREAKING CHANGES * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ### Features * Add cli argument to control image download ([#1495](#1495)) ([f210a76](f210a76)) ### Bug Fixes * run_sh doesn't remove new lines from input ([#1642](#1642)) ([a969dff](a969dff)) ### Code Refactoring * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ([e7ab58a](e7ab58a)), closes [#843](#843) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]> Co-authored-by: leoporoli <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
## Description: Improve description of the image-download flag in both CLI help and docs. ## Is this change user facing? YES ## References (if applicable): - fix on #1495 for #1299 --------- Co-authored-by: Derek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new cli argument to control how to download the latest images.
Is this change user facing?
YES
References (if applicable):
This PR is aimed to address #1299