kurtosis service logs --follow creates a busy loop in closeChannelWhenEmpty

[praetoriansentry]

What's your CLI version?

1.4.1

Description & steps to reproduce

Spin up something:

kurtosis run --enclave my-testnet github.com/ethpandaops/[email protected]

Follow the logs a few times:

kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &
kurtosis service logs --follow my-testnet el-1-geth-lighthouse &

At this point everything is fine. But if you stop those processes, each call will use 100% CPU:

ps aux | grep 'kurtosis service logs' | grep -v grep | awk '{print $2}' | xargs kill

At this point the kurtosis-engine process will be using roughly 1000% cpu.

Desired behavior

I guess this loop should either have a delay for some kind of upper bound on the amount of time that it will wait.
https://github.com/kurtosis-tech/kurtosis/blob/v1.4.1/engine/server/engine/centralized_logs/client_implementations/persistent_volume/persistent_volume_logs_database_client.go#L178-L185

Since it's looping forever, I would guess the check on len(logsChan) isn't doing what we expect.

What is the severity of this bug?

Papercut; this bug is frustrating, but I have a workaround.

What area of the product does this pertain to?

CLI: the Command Line Interface

[tedim52]

Looking into this now