fix: Make sure that the tags are fetched before testing with git describe #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
reviewed
Jan 15, 2024
leoporoli
approved these changes
Jan 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.6](0.86.5...0.86.6) (2024-01-16) ### Features * allow any GitHub path on the `upload_files` instruction ([#2044](#2044)) ([75fcf3f](75fcf3f)) ### Bug Fixes * Make sure that the tags are fetched before testing with git describe ([#2047](#2047)) ([b8e7afb](b8e7afb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes the issue seen in https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/10677/workflows/66565433-39e0-4397-b0d8-4c3c81ad366b/jobs/152621.
When ci checks out code in a step it doesn't fetch tags, so
git describe --exact-matchwill always fail - this change fixes this by fetching tags.Is this change user facing?
NO
References (if applicable):
-chore: only run
build_enclave_manager_webappon non docs changes and tagged commits #2041