Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pr-audit.yml, add the missing name field to the audit.yml file #96

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

kurosakishigure
Copy link
Owner

@kurosakishigure kurosakishigure commented Dec 18, 2024

Description

  • Add pr-audit.yml
  • Add the missing name field to the audit.yml file
  • Fix unable to find version latest
  • Fix no ast-grep project configuration is found
  • Fix no such file or directory
  • Fix init assertion failed
  • What is the purpose of this PR?
  • What problem does it solve?
  • Are there any breaking changes or backwards compatibility issues?
    • Due to the introduction of new linting rules, we might need some time to adjust and monitor for bugs

Related Issue

Type of Change

  • New feature

How Has This Been Tested?

  • I have run unit tests
  • I have tested the changes manually
  • I have tested in a staging environment

Checklist

  • My code follows the coding style guidelines of this project
  • I have written or updated relevant documentation (if applicable)
  • I have added or updated tests to cover my changes (if applicable)
  • All new and existing tests pass
  • I have reviewed my code for any potential issues
  • Link the relevant issue to this PR (if applicable)
  • Add labels to this PR
  • I have read and followed the guidelines in CONTRIBUTING.md

Additional Notes

None.

@kurosakishigure kurosakishigure added the enhancement New feature or request label Dec 18, 2024
@kurosakishigure kurosakishigure marked this pull request as draft December 18, 2024 22:13
@kurosakishigure
Copy link
Owner Author

We have observed that during the CI process, there is a chance that the file content read at line 50 in tests/cmd.rs might be empty. To address this, we plan to first upgrade the dependencies in Cargo.lock.

@kurosakishigure kurosakishigure marked this pull request as ready for review December 18, 2024 23:03
@kurosakishigure
Copy link
Owner Author

kurosakishigure commented Dec 18, 2024

I ran it four times, and the issue seems to be resolved—hopefully! It appears to be a problem with the dependency miniz_oxide. It has affected Tokio, This is so weird! :(

@kurosakishigure kurosakishigure merged commit 1229725 into canary Dec 18, 2024
14 checks passed
@kurosakishigure kurosakishigure deleted the feat/pr_audit branch December 18, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pr-audit.yml file
1 participant