proposal:Add Gateway Plugin Support #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gidi233 <[email protected]>
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
almost will.
/cc @hzxuzhonghu Do you have time to look at it?
|
|
||
| ### Summary | ||
|
|
||
| Kurator's release feature currently relies on the Istio gateway plugin to manage traffic distribution. To provide users with more options, we aim to extend Kurator's release feature to support additional common gateway plugins such as NGINX and Kuma. |
There was a problem hiding this comment.
Suggested change
| Kurator's release feature currently relies on the Istio gateway plugin to manage traffic distribution. To provide users with more options, we aim to extend Kurator's release feature to support additional common gateway plugins such as NGINX and Kuma. | |
| Kurator's rollout feature currently relies on the Istio gateway plugin to manage traffic distribution. To provide users with more options, we aim to extend Kurator's rollout feature to support additional common gateway plugins such as NGINX and Kuma. |
change reslease to Rollout in this proposal
| type TrafficRoutingConfig struct { | ||
| ... | ||
| // for NGINX | ||
| // 默认创建的ingress如下,(replace app.example.com with your own domain,并根据需求更改路径匹配规则) |
Signed-off-by: Gidi233 <[email protected]>
|
/lgtm |
hzxuzhonghu
approved these changes
Jul 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Extend the gateway plugins supported by Kurator's release feature, initially including NGINX and Kuma.
Which issue(s) this PR fixes:
Fixes #651
Does this PR introduce a user-facing change?: