Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loglevel-string #12

Merged
merged 5 commits into from
Sep 19, 2023
Merged

loglevel-string #12

merged 5 commits into from
Sep 19, 2023

Conversation

jmnote
Copy link
Contributor

@jmnote jmnote commented Sep 19, 2023

What this PR does / why we need it (변경 내용 / 필요성):

LogLevel을 string으로 변환하는 메소드 추가

Which issue(s) this PR fixes (관련 이슈):

Special notes for your reviewer (리뷰어에게 하고 싶은 말):

리뷰 감사합니다.

Additional documentation, usage docs, etc. (기타 관련 문서, 사용법 등):

@jmnote jmnote added the enhancement New feature or request label Sep 19, 2023
@jmnote jmnote self-assigned this Sep 19, 2023
@jmnote jmnote linked an issue Sep 19, 2023 that may be closed by this pull request
@pull-request-size pull-request-size bot added size/L and removed size/S labels Sep 19, 2023
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@jmnote jmnote requested a review from dozer-jang September 19, 2023 03:30
Copy link
Contributor

@dozer-jang dozer-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String 메서드를 추가한 것 확인했습니다~ 근데 어떤 부분의 필요로 구현하신건지 잘 예상이 안되네요

@jmnote jmnote merged commit 601f318 into main Sep 19, 2023
7 checks passed
@jmnote jmnote deleted the loglevel-string branch September 19, 2023 04:56
@jmnote
Copy link
Contributor Author

jmnote commented Sep 19, 2023

리뷰 감사합니다. 이 기능의 사용사례는 나중에 댓글로 달겠습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logLevel.String()
3 participants