solve the problem of not finding the same name table #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuwei-ck
reviewed
May 26, 2021
liuwei-ck
approved these changes
May 26, 2021
liuwei-ck
reviewed
May 26, 2021
liuwei-ck
approved these changes
May 26, 2021
Closed
rejohn
approved these changes
May 26, 2021
sql/pq_clone.cc
Outdated
| bool is_same_table(QEP_TAB *src, const char *db, const char *table_name, const char *table_ref_alias) { | ||
| if (!strncmp(db, src->db->str, strlen(db)) && | ||
| strlen(src->db->str) == strlen(db) && | ||
| !strncmp(table_name, src->table_name->str, strlen(table_name)) && |
There was a problem hiding this comment.
使用strcmp 替代 strncmp 和strlen 。目的是为了比较字符串是否相等，使用strcmp即可
rejohn
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1：优化对表名称相同情况下的处理，增加一个判断需要的条件
2：对应解决mtr:main.type_decimal, main.func_set, main.implicit_commit