Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer pool page_hash_locks optimization #126

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Buffer pool page_hash_locks optimization #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions storage/innobase/handler/ha_innodb.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21111,13 +21111,11 @@ static MYSQL_SYSVAR_ULONGLONG(
ulonglong{srv_buf_pool_chunk_unit_max},
ulonglong{srv_buf_pool_chunk_unit_blk_sz});

#if defined UNIV_DEBUG || defined UNIV_PERF_DEBUG
static MYSQL_SYSVAR_ULONG(page_hash_locks, srv_n_page_hash_locks,
PLUGIN_VAR_OPCMDARG | PLUGIN_VAR_READONLY,
"Number of rw_locks protecting buffer pool "
"page_hash. Rounded up to the next power of 2",
nullptr, nullptr, 16, 1, MAX_PAGE_HASH_LOCKS, 0);
zwang28 marked this conversation as resolved.
Show resolved Hide resolved
#endif /* defined UNIV_DEBUG || defined UNIV_PERF_DEBUG */

// clang-format off
static MYSQL_SYSVAR_BOOL(
Expand Down Expand Up @@ -22123,9 +22121,7 @@ static SYS_VAR *innobase_system_variables[] = {
MYSQL_SYSVAR(merge_threshold_set_all_debug),
MYSQL_SYSVAR(semaphore_wait_timeout_debug),
#endif /* UNIV_DEBUG */
#if defined UNIV_DEBUG || defined UNIV_PERF_DEBUG
MYSQL_SYSVAR(page_hash_locks),
#endif /* defined UNIV_DEBUG || defined UNIV_PERF_DEBUG */
MYSQL_SYSVAR(status_output),
MYSQL_SYSVAR(status_output_locks),
MYSQL_SYSVAR(print_all_deadlocks),
Expand Down
2 changes: 1 addition & 1 deletion storage/innobase/include/buf0buf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ constexpr ulint MAX_BUFFER_POOLS = (1 << MAX_BUFFER_POOLS_BITS);
#define BUF_POOL_WATCH_SIZE (srv_n_purge_threads + 1)

/** The maximum number of page_hash locks */
constexpr ulint MAX_PAGE_HASH_LOCKS = 1024;
constexpr ulint MAX_PAGE_HASH_LOCKS = 1048576;

/** The buffer pools of the database */
extern buf_pool_t *buf_pool_ptr;
Expand Down