Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexer from Arnauld & Module Dependency scope from me #24

Open
wants to merge 226 commits into
base: master
Choose a base branch
from

Conversation

witspirit
Copy link

Hi Aman,

I recently stumbled on your IntelliJBehave plugin and found it very helpful. However, in my project setup I experienced some issues regarding sluggishness and in some cases steps failed to be found.

To overcome these issues I modified your plugin to search for steps in the module containing the story file and the module dependencies.

In addition we used some story syntax that was not handled properly by your current lexer and parser. I found another github user, arnauld, had already done quite some work in creating a new lexer/parser (not sure, but he seems the lead on the Eclipse JBehave plugin) and merged that in.

If you are still interested in persueing this plugin, I propose you consider pulling in the changes I already aggregated and perhaps you could release a new version in the JetBrains repository.

If, however, you are no longer interested in following up on this plugin, I would like to know whether it would be ok for me to publish a new version in the JetBrains repository with proper attribution.

Kind regards,

Bert Van Vlerken (https://github.com/witspirit)

jarosite and others added 28 commits May 9, 2012 02:53
…pletion support + add parameter highlighting in step
* Allow text between step and table
* Don't include table in step
…e/IntelliJBehave

And resolved conflicts in:
	.gitignore
	IntelliJBehave.iml
	META-INF/plugin.xml
	src/com/github/kumaraman21/intellijbehave/parser/StoryParser.java
	src/com/github/kumaraman21/intellijbehave/resolver/StepDefinitionIterator.java
	src/com/github/kumaraman21/intellijbehave/resolver/StepPsiReference.java

* Added a pom to download some dependencies
* Fiddled with the IML file... Probably not yet what it should be

Basics are working, using my 'story' project approach.
…e/IntelliJBehave

And resolved conflicts in:
	.gitignore
	IntelliJBehave.iml
	META-INF/plugin.xml
	src/com/github/kumaraman21/intellijbehave/parser/StoryParser.java
	src/com/github/kumaraman21/intellijbehave/resolver/StepDefinitionIterator.java
	src/com/github/kumaraman21/intellijbehave/resolver/StepPsiReference.java

* Added a pom to download some dependencies
* Fiddled with the IML file... Probably not yet what it should be

Basics are working, using my 'story' project approach.

(Some missing files from previous commit...)
… file (except for the special JFlex)

* Uses copy-dependencies to get the necessary jars and put them in the appropriate location
* Uses clean to also cleanup the jars it copies there

This way, I don't have to check in the binaries. Which is as it should be.
* Inverted responsibility for the content iteration
* Renamed ProjectUtils to ScanUtils to better reflect responsibility
* Scan Module and Module Dependencies for steps instead of entire Project
@atifmansoor
Copy link

Hi Bert,
First of all, I would like to thank you (+Arnauld+jarosite) for your work and contributions to this project.

Now, can you go ahead and publish this new version (under a new name) to the Plugin Repository? I believe if you publish under a new name, include the license and proper attribution, we should be "fine". Correct me if I'm wrong.

Atif

@witspirit
Copy link
Author

Hi Atif,

Thanks for getting back to me.

If you no longer seek to update the plugin, I'd be happy to prepare a
version to publish under a new name, with proper attribution and license.
Thanks for your advice on the matter.

Thanks again for getting this plugin started.

Cheers,

Bert

On Thu, Mar 14, 2013 at 7:47 PM, Atif Mansoor [email protected]:

Hi Bert,
First of all, I would like to thank you (+Arnauld+jarosite) for your work
and contributions to this project.

Now, can you go ahead and publish this new version (under a new name) to
the Plugin Repository? I believe if you publish under a new name, include
the license and proper attribution, we should be "fine". Correct me if I'm
wrong.

Atif


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-14921603
.

picimako added 30 commits May 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.