Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) change failpolicy of service hook to ignore #983

Merged
merged 1 commit into from
Aug 21, 2020
Merged

feat(kuma-cp) change failpolicy of service hook to ignore #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5721,7 +5721,7 @@ webhooks:
- proxytemplates
sideEffects: None
- name: service.validator.kuma-admission.kuma.io
failurePolicy: Fail
failurePolicy: Ignore
clientConfig:
caBundle: Q0VSVA==
service:
Expand Down
4 changes: 2 additions & 2 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5575,7 +5575,7 @@ webhooks:
- proxytemplates
sideEffects: None
- name: service.validator.kuma-admission.kuma.io
failurePolicy: Fail
failurePolicy: Ignore
clientConfig:
caBundle: Q0VSVA==
service:
Expand Down Expand Up @@ -5615,4 +5615,4 @@ webhooks:
- DELETE
resources:
- secrets
sideEffects: None
sideEffects: None
2 changes: 1 addition & 1 deletion app/kumactl/cmd/install/testdata/install-control-plane.global.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5558,7 +5558,7 @@ webhooks:
- proxytemplates
sideEffects: None
- name: service.validator.kuma-admission.kuma.io
failurePolicy: Fail
failurePolicy: Ignore
clientConfig:
caBundle: Q0VSVA==
service:
Expand Down
2 changes: 1 addition & 1 deletion app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5588,7 +5588,7 @@ webhooks:
name: kuma-ctrl-plane
namespace: kuma
path: /validate-v1-service
failurePolicy: Fail
failurePolicy: Ignore
name: service.validator.kuma-admission.kuma.io
rules:
- apiGroups:
Expand Down
2 changes: 1 addition & 1 deletion app/kumactl/cmd/install/testdata/install-control-plane.remote.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5583,7 +5583,7 @@ webhooks:
- proxytemplates
sideEffects: None
- name: service.validator.kuma-admission.kuma.io
failurePolicy: Fail
failurePolicy: Ignore
clientConfig:
caBundle: Q0VSVA==
service:
Expand Down
2 changes: 1 addition & 1 deletion app/kumactl/data/install/k8s/control-plane/kuma-cp/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ webhooks:
- proxytemplates
sideEffects: None
- name: service.validator.kuma-admission.kuma.io
failurePolicy: Fail
failurePolicy: Ignore
clientConfig:
caBundle: {{ .AdmissionServerTlsCert | b64enc }}
service:
Expand Down
8 changes: 4 additions & 4 deletions app/kumactl/pkg/install/k8s/control-plane/templates_vfsdata.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion deployments/charts/kuma/templates/cp-webhooks-and-secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ webhooks:
- proxytemplates
sideEffects: None
- name: service.validator.kuma-admission.kuma.io
failurePolicy: Fail
failurePolicy: Ignore
clientConfig:
caBundle: {{ $admissionCaBundle }}
service:
Expand Down