-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cni): support port exclusion for UIDs #8319
fix(kuma-cni): support port exclusion for UIDs #8319
Conversation
…s-for-uids' and 'traffic.kuma.io/exclude-outbound-udp-ports-for-uids' annotations Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, two things to consider:
- have you checked if there are other annotations that are missing parsing and only works in init-containers?
- should we add a comment in init-container and cni that until Add a more systematic way to add transparent-proxy config #8324 is resolved new annotations need to be added in both places?
|
@bartsmykla this should be configurable as well, right? edit: https://github.com/kumahq/kuma/pull/2221/files#r659633047 |
I think it should be configurable as current approach of always setting the default UID is incorrect when we would change via |
Signed-off-by: Ilya Lobkov <[email protected]>
Only
failed so I'm merging this since improvement for it is already in the branch |
Kuma Init container supports the following pod annotations:
traffic.kuma.io/exclude-outbound-tcp-ports-for-uids
traffic.kuma.io/exclude-outbound-udp-ports-for-uids
but Kuma CNI doesn't. Current PR adds support for these annotations for Kuma CNI.
Ideally, we'd like to converge Kuma CNI and Transparent Proxy code bases to share parsing and config structures.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --