Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): don't configure RBAC rules on Prometheus listener #8172

Merged

Conversation

lobkovilya
Copy link
Contributor

This issue is currently blocking us from fully switching from TrafficPermission to MeshTrafficPermissions.

After a discussion with @lahabana we want to stop treating Prometheus listeners as an inbound for "fake" service. Instead MeshMetric policy when implemented should contain a configuration of what service is allowed to access the Prometheus listener.

Checklist prior to review

@lobkovilya lobkovilya requested a review from a team as a code owner October 27, 2023 15:55
@lobkovilya lobkovilya requested review from michaelbeaumont and lukidzi and removed request for a team October 27, 2023 15:55
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, but tests are not passing

Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is intentional

https://kuma.io/docs/2.4.x/policies/traffic-metrics/

        tags: # tags that can be referred in Traffic Permission when metrics are secured by mTLS  
          kuma.io/service: dataplane-metrics

edit: read the PR description. This needs docs + UPGRADE.md change if we want to change it

@lobkovilya lobkovilya merged commit 0fa57e9 into kumahq:master Oct 31, 2023
5 checks passed
@lobkovilya lobkovilya deleted the fix/no-rbac-on-prometheus-listener branch October 31, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshTrafficPermission: prometheus listener doesn't allow traffic with allow-all policy
3 participants