chore(kuma-cp) prometheus overrides on Kubernetes #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
approved these changes
Jun 3, 2020
nickolaev
reviewed
Jun 3, 2020
| pod: "07.pod.yaml", | ||
| servicesForPod: "07.services-for-pod.yaml", | ||
| dataplane: "07.dataplane.yaml", | ||
| }), |
There was a problem hiding this comment.
So this is the actual test to verify that we can't break the feature next time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some time ago overrides for port and path was done using
prometheus.ioannotations (Kuma prometheus annotations were converted to prometheus) because Kuma DP discovery was based onprometheus.ioannotations. Later we changed this so discovery of Kuma DP is based onkuma-prometheus-sdand we leaveprometheus.ioannotations for apps.In the process of this change, we lost the ability to override port and path of Kuma DP metrics on Pod. This PR restores this functionality, so we convert Kuma Metrics annotations to DP config.
Documentation
Already there