Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): fix passing logs to pglock #8040

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 12, 2023

Pglock expects a format and values in the log calls. Like here:

https://github.com/cirello-io/pglock/blob/1de056ea4454e146d4f93fc92368c9f2850a3a5c/client.go#L195.

This is why up until now we've seen these weird logs like this:

error: %v

in our logs.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- not reported via issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka requested a review from a team as a code owner October 12, 2023 11:20
@slonka slonka requested review from jakubdyszkiewicz and bartsmykla and removed request for a team October 12, 2023 11:20
@bartsmykla bartsmykla enabled auto-merge (squash) October 16, 2023 03:06
@bartsmykla bartsmykla merged commit 446d175 into kumahq:master Oct 16, 2023
5 checks passed
@lahabana lahabana changed the title fix(pglock): fix passing logs to pglock fix(postgres): fix passing logs to pglock Nov 3, 2023
@lahabana lahabana changed the title fix(postgres): fix passing logs to pglock fix(store): fix passing logs to pglock Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants