Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix ca):Updated Ca Certificate Expiration and Rotation by adding a c… #794

Merged
merged 3 commits into from
Jun 2, 2020
Merged

(fix ca):Updated Ca Certificate Expiration and Rotation by adding a c… #794

merged 3 commits into from
Jun 2, 2020

Conversation

tharun208
Copy link
Contributor

@tharun208 tharun208 commented Jun 2, 2020 •
edited by nickolaev
Loading

Summary

SUMMARY_GOES_HERE
Initially, #750 fixes this issue by using go's inbuilt ParseDuration fn. But missed that It won't support for y, m format. So, this PR contains the fix for that by adding a custom ParseDuration function.

Full changelog

  • Added a custom ParseDuration in mesh helper
  • Updated tests

Issues resolved

Fix #743

Docs in kumahq/kuma-website#209

@tharun208 tharun208 requested a review from a team June 2, 2020 13:52
nickolaev
nickolaev suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you enhance the mesh_helpets_test.go and verify the solution works against various strings. Some ideas you might want to try:

  • 1y5d
  • 3d4h
  • 2w4h15m
  • 1d50m17s

pkg/core/resources/apis/mesh/mesh_helpers.go Show resolved Hide resolved
@nickolaev nickolaev merged commit 849112f into kumahq:master Jun 2, 2020
@tharun208 tharun208 deleted the certificate-custom-parseDuration branch June 23, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse durations with y, h, m suffixes properly.
2 participants
@tharun208 @nickolaev