-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-server): improve error handling and return status #7937
Conversation
Nice, I like this direction very much. Our error handling bothers me. It would be nice to create a set of rules as we have for logging https://github.com/kumahq/kuma/blob/master/docs/madr/decisions/003-logging.md
I'm up to writing this down. |
@jakubdyszkiewicz I think it makes sense to have a MADR (also because implementing things like |
/golden_files |
- never return 412 (it was never appropriate - create better error hierarchy to simplify handler - use in some places errors.Is Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?