Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): take proper context for resync #7805

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 21, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lukidzi lukidzi requested a review from a team as a code owner September 21, 2023 07:18
@lukidzi lukidzi requested review from jakubdyszkiewicz and lobkovilya and removed request for a team September 21, 2023 07:18
@lukidzi lukidzi enabled auto-merge (squash) September 21, 2023 07:25
@jakubdyszkiewicz jakubdyszkiewicz added the ci/skip-e2e-test PR: Don't run e2e tests label Sep 21, 2023
@lukidzi lukidzi merged commit b4e197e into kumahq:master Sep 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants