Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sec): get rid of dependency on containerd #7387

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix(sec): get rid of dependency on containerd #7387

merged 1 commit into from
Jul 31, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jul 30, 2023 •
edited
Loading

Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- reported via slack
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) -- already covered
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- yes
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jul 30, 2023
@slonka slonka requested a review from a team as a code owner July 30, 2023 18:04
@slonka slonka requested review from jakubdyszkiewicz and lobkovilya and removed request for a team July 30, 2023 18:04
@slonka
fix(sec): get rid of dependency on containerd
db75a02 
Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
@slonka slonka force-pushed the get-rid-of-dependency-on-cgroups branch from 8b44fe2 to db75a02 Compare July 30, 2023 18:05
@slonka slonka enabled auto-merge (squash) July 30, 2023 19:36
@slonka slonka merged commit 490549e into kumahq:master Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023 •
edited
Loading

backporting to release-2.0 with action

backporting to release-2.1 with action
backporting to release-2.3 with action
backporting to release-1.8 with action

This was referenced Jul 31, 2023
Merged
Merged
Merged
kumahq bot pushed a commit that referenced this pull request Jul 31, 2023
@slonka @kumahq
fix(sec): get rid of dependency on containerd (#7387)
896be87 
Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
kumahq bot pushed a commit that referenced this pull request Jul 31, 2023
@slonka @kumahq
fix(sec): get rid of dependency on containerd (#7387)
301220e 
Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
kumahq bot pushed a commit that referenced this pull request Jul 31, 2023
@slonka @kumahq
fix(sec): get rid of dependency on containerd (#7387)
334b55b 
Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
kumahq bot pushed a commit that referenced this pull request Jul 31, 2023
@slonka @kumahq
fix(sec): get rid of dependency on containerd (#7387)
f726a83 
Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
This was referenced Jul 31, 2023
Merged
Merged
kumahq bot pushed a commit that referenced this pull request Jul 31, 2023
@slonka @kumahq
fix(sec): get rid of dependency on containerd (#7387)
d139418 
Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
slonka added a commit that referenced this pull request Jul 31, 2023
@kumahq @slonka
fix(sec): get rid of dependency on containerd (backport of #7387) (#7391
a19b208 
)

* fix(sec): get rid of dependency on containerd (#7387)

Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>

* fix(sec): resolve confcits

Signed-off-by: slonka <[email protected]>

* fix(sec): update vulnerable dependency

Signed-off-by: slonka <[email protected]>

* chore(lint): make check pass

Signed-off-by: slonka <[email protected]>

* chore(lint): go mod tidy

Signed-off-by: slonka <[email protected]>

* chore(lint): make check pass

Signed-off-by: slonka <[email protected]>

---------

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
slonka added a commit that referenced this pull request Jul 31, 2023
@kumahq @slonka
fix(sec): get rid of dependency on containerd (backport of #7387) (#7392
2fd5084 
)

* fix(sec): get rid of dependency on containerd (#7387)

Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka @michaelbeaumont
fix(sec): get rid of dependency on containerd (backport of #7387) (#7393
ee0e8b7 
)

* fix(sec): get rid of dependency on containerd (#7387)

Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

* fix(sec): resolve confcits
* chore(lint): change indent
* chore: upgrade testcontainers-go

Signed-off-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka @michaelbeaumont
fix(sec): get rid of dependency on containerd (backport of #7387) (#7390
6983120 
)

* fix(sec): get rid of dependency on containerd (#7387)

Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

* fix(sec): resolve confcits
* chore(lint): make check pass
* chore(lint): change indent
* chore: upgrade testcontainers-go

Signed-off-by: slonka <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 2, 2023
@kumahq @slonka @michaelbeaumont
fix(sec): get rid of dependency on containerd (backport of #7387) (#7389
ffae6c2 
)

* fix(sec): get rid of dependency on containerd (#7387)

Containerd shows up time and time again with a CVE that does not actually impact our codebase but looks not great in scan results. I copied the code from the source so we no longer rely on it.

* fix(sec): resolve confcits
* chore(lint): change indent
* chore: upgrade testcontainers-go

Signed-off-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(sec): get rid of dependency on containerd (backport of #7387
849ea1a 
) (#7393)"

This reverts commit ee0e8b7.
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(sec): get rid of dependency on containerd (backport of ku…
e4b3842 
…mahq#7387) (kumahq#7389)"

This reverts commit ffae6c2.
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(sec): get rid of dependency on containerd (backport of #7387
b1ea688 
) (#7389)"

This reverts commit ffae6c2.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(sec): get rid of dependency on containerd (backport of #7387
516bf5f 
) (#7391)"

This reverts commit a19b208.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(sec): get rid of dependency on containerd (backport of #7387
be825b1 
) (#7391)"

This reverts commit a19b208.
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
build(go.mod): revert containerd changes (#7437)
8e64641 
* Revert "fix(containerd): only build cgroups on linux (backport of #7408) (#7423)"
This reverts commit e2af55b.
* Revert "fix(sec): get rid of dependency on containerd (backport of #7387) (#7389)"
This reverts commit ffae6c2.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
build(go.mod): revert containerd changes (#7436)
78d0f05 
* Revert "fix(containerd): only build cgroups on linux (backport of #7408) (#7426)"
This reverts commit c7334f3.
* Revert "fix(sec): get rid of dependency on containerd (backport of #7387) (#7393)"
This reverts commit ee0e8b7.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
Revert "fix(sec): get rid of dependency on containerd (backport of #7387
c5e6206 
) (#7390)"

This reverts commit 6983120.

Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont added a commit that referenced this pull request Aug 3, 2023
@michaelbeaumont
build(go.mod): revert containerd changes (#7445)
480806e 
Revert "fix(sec): get rid of dependency on containerd (backport of #7387) (#7390)"

This reverts commit 6983120.

Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonka @jakubdyszkiewicz