-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp): cancel OnTick when watchdog stopped #7221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
fix/watchdog
branch
from
July 11, 2023 22:57
78cc476
to
044d838
Compare
michaelbeaumont
changed the title
fix(kuma-cp): pass context via snapshot reconciler to generateCerts
fix(kuma-cp): stop OnTick when watchdog stopped
Jul 11, 2023
michaelbeaumont
force-pushed
the
fix/watchdog
branch
from
July 11, 2023 23:45
c931281
to
76662ce
Compare
michaelbeaumont
added
the
ci/run-full-matrix
PR: Runs all possible e2e test combination (expensive use carefully)
label
Jul 12, 2023
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/watchdog
branch
from
July 12, 2023 08:18
76662ce
to
b6fe510
Compare
michaelbeaumont
requested review from
Automaat and
lobkovilya
and removed request for
a team
July 12, 2023 08:52
lobkovilya
approved these changes
Jul 12, 2023
might be interesting to know why it's nil, but if it recovers in 100% cases than switch from |
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
fix/watchdog
branch
from
July 13, 2023 12:20
b6fe510
to
9d4425d
Compare
michaelbeaumont
changed the title
fix(kuma-cp): stop OnTick when watchdog stopped
fix(kuma-cp): cancel OnTick when watchdog stopped
Jul 13, 2023
Signed-off-by: Mike Beaumont <[email protected]>
lobkovilya
approved these changes
Jul 13, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]>
This was referenced Jul 13, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Jul 13, 2023
…#7241) fix(kuma-cp): cancel OnTick when watchdog stopped (#7221) * fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Jul 13, 2023
* fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Jul 13, 2023
…#7242) fix(kuma-cp): cancel OnTick when watchdog stopped (#7221) * fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Jul 13, 2023
…#7240) fix(kuma-cp): cancel OnTick when watchdog stopped (#7221) * fix(kuma-cp): stop OnTick when watchdog stopped * fix: contextcheck error * test: update for signature change * fix: check if stopped before ticking Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SimpleWatchdog.OnTick
from thedataplaneWatchdogFactory
, i.e. snapshot generation, takes a very long time and the proxy disconnects and reconnects, theContext
used inOnTick
is never canceled, becauseOnTick
never returns and we thus never seestop
being closed.Additionally, we did not pass anOnTick
Context
down into theGenerators
, in particular, togenerateCerts
.I intentionally don't touch hds, mads or kds with this PR.
OnTick error: metadata cannot be nil
?@slonka @bartsmykla WDYT? this is a good example of an "error" that's not an alarming errorChecklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?