feat(kuma-cp) dataplane certificate rotation #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR also introduce new properties for |
|
@subnetmarco I still need to do builtin CA expiration and rsaBits. I'll update docs after this change |
jakubdyszkiewicz
force-pushed
the
parametrize-expiration
branch
from
c6075e1 to
8a24bd6
Compare
lobkovilya
approved these changes
May 12, 2020
| return false, "", errors.Wrap(err, `invalid snapshot version format. Format should be "UnixNano;NameOfTheCA"`) | ||
| } | ||
| expiration := issuer.DefaultWorkloadCertValidityPeriod | ||
| if mesh.GetEnabledCertificateAuthorityBackend().GetDpCert().GetRotation().GetExpiration() != nil { |
There was a problem hiding this comment.
I think makes sense to specify MinWorkloadCertValidityPeriod to avoid a mess with small values
There was a problem hiding this comment.
Can you elaborate here? What will be the mess with small values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce certificate rotation after 4/5 life of the certificate.
Also changed the default expiration to 30 days.