Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): error status is an int #7162

Merged
merged 1 commit into from
Jul 4, 2023
Merged

feat(api): error status is an int #7162

merged 1 commit into from
Jul 4, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jul 4, 2023 •
edited by lahabana
Loading

Changelog: feat(api-server): error status is an int

Checklist prior to review

Fix #7117

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
feat(api): error status is an int
582012a 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner July 4, 2023 11:12
@jakubdyszkiewicz jakubdyszkiewicz requested review from slonka and bartsmykla and removed request for a team July 4, 2023 11:12
@jakubdyszkiewicz jakubdyszkiewicz merged commit 4715080 into kumahq:master Jul 4, 2023
slonka pushed a commit to slonka/kuma that referenced this pull request Jul 19, 2023
@jakubdyszkiewicz @slonka
feat(api): error status is an int (kumahq#7162)
0c05292 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API errors contain status field as string instead of integer
2 participants
@jakubdyszkiewicz @lahabana