-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kumactl get commands with age column #702
Conversation
Hey, I tested the PR and there is a problem
It always shows zero. I think that due to rounding it will only show hours. I think it should look like this: @subnetmarco thoughts? |
Yes I agree @jakubdyszkiewicz. @tharun208 can you implement this behavior? |
sure will update it, @subnetmarco |
Hi @subnetmarco, @jakubdyszkiewicz can we show the age in |
removed age formatting function from get package
53a4a3d
to
1c7b2eb
Compare
1c7b2eb
to
a922909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it works great 👍
Still needs some small changes about code.
updated inspect dataplanes Ago method to use duration helper
Thanks for iterating on this! |
Summary
Age column for kumactl table view
Full changelog
Added Age Column for the following
Updated
inspect DataPlanes
lastConnected and lastUpdated to the new formatUpdated tests