-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): improve BuildRules algorithm #6973
Merged
lobkovilya
merged 11 commits into
kumahq:master
from
lobkovilya:feat/improve-rules-algo
Jun 12, 2023
Merged
feat(kuma-cp): improve BuildRules algorithm #6973
lobkovilya
merged 11 commits into
kumahq:master
from
lobkovilya:feat/improve-rules-algo
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
lobkovilya
requested review from
a team,
jakubdyszkiewicz and
lukidzi
and removed request for
a team
June 8, 2023 16:58
lahabana
approved these changes
Jun 9, 2023
6 tasks
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Co-authored-by: Charly Molter <[email protected]> Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
jakubdyszkiewicz
approved these changes
Jun 12, 2023
michaelbeaumont
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing
targetRef.Kind: MeshHTTPRoute
I've encountered the problem whenBuildRules
returns excessive results because I'm adding an artificial tag__route_hash__
to the Subset.But the problem could be noticed even for the given MeshTrafficPermission policy:
the algorithm is going to produce 2 excessive rules:
The algorithm splits frontend service into
v1
andnot v1
but there is absolutely no reason for that. This happens because the current algorithm assumes that all provided rules could have an intersection. The new algorithm takes this into account. As a result, we're going to produce fewer rules, for example:Old algorithm Inspect API:
New algorithm Inspect API:
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?