feat(MeshTCPRoute): add policy logic #6873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commint introduces logic for applying `MeshTCPRoute` policy, enables already existing unit tests for verifycation of generated xdsresources and enables already extisting e2e tests. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
a team,
slonka and
lobkovilya
and removed request for
a team
21 tasks
Signed-off-by: Bart Smykla <[email protected]>
lobkovilya
reviewed
May 30, 2023
pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners_backendrefs.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners_backendrefs.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners_backendrefs.go
Show resolved
Hide resolved
pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners_filterchain.go
Show resolved
Hide resolved
`toRulesHTTP` and `toRulesTCP` is more consistent than `httpRules` and `tcpRules` Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
6 tasks
This was referenced Jun 2, 2023
michaelbeaumont
approved these changes
Jun 6, 2023
lobkovilya
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logic for applying
MeshTCPRoutepolicy, enables already existing unit tests for verification of generated xds resources and enables already existing e2e tests.Closes: #6787
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OSUPGRADE.md?> Changelog:entry here or add aci/label to run fewer/more tests?