Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(MeshTCPRoute): small name fix in e2e test case #6859

Merged

Conversation

bartsmykla
Copy link
Contributor

Very small fix in the name of service in e2e test case for MeshTCPRoute

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • it won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • it's a fix in an e2e test case actually
  • Do you need to update UPGRADE.md?
    • there is no need
  • Does it need to be backported according to the backporting policy?
    • there is no need
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?
    • there is no need

@bartsmykla bartsmykla added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label May 29, 2023
@bartsmykla bartsmykla requested review from slonka, a team and lobkovilya and removed request for a team May 29, 2023 10:28
@bartsmykla bartsmykla mentioned this pull request May 29, 2023
21 tasks
@bartsmykla bartsmykla enabled auto-merge (squash) May 29, 2023 10:29
@bartsmykla bartsmykla merged commit 80a00b8 into kumahq:master May 29, 2023
@bartsmykla bartsmykla deleted the chore/small-fix-in-meshtcproute-e2e-test branch May 29, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants