Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MeshTCPRoute): add e2e tests + generated files #6846

Conversation

bartsmykla
Copy link
Contributor

This patch introduces e2e tests (temporarily paused) for MeshTCPRoute, and it contains all pre-generated files which are registering empty for now policy.

It's done to divide the whole plugin implementation to as small and consumable chunks as possible.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • e2e tests is the only non-generated logic this PR contains
  • Do you need to update UPGRADE.md?
    • there is no need as it's a non-released yet policy
  • Does it need to be backported according to the backporting policy?
    • there is no need as it's a non-released yet policy
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?
    • there is no need

This patch introduces e2e tests (temporarily paused) for MeshTCPRoute,
and it contains all pre-generated files which are registering empty for
now policy.

It's done to divide the whole plugin implementation to as small and
consumable chunks as possible.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested review from a team, slonka and lukidzi and removed request for a team May 25, 2023 12:12
@bartsmykla bartsmykla mentioned this pull request May 25, 2023
21 tasks
@bartsmykla
Copy link
Contributor Author

/format

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bartsmykla bartsmykla enabled auto-merge (squash) May 26, 2023 08:23
Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla disabled auto-merge May 26, 2023 08:34
@bartsmykla bartsmykla enabled auto-merge (squash) May 26, 2023 08:35
@bartsmykla bartsmykla merged commit eeeb305 into kumahq:master May 26, 2023
@bartsmykla bartsmykla deleted the feat/empty-meshtcproute-policy-with-e2e-tests branch May 26, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants