fix(kumactl) added shorthand command name for mesh #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added shorthand message for mesh argument in kumactl Fix kumahq#662
jakubdyszkiewicz
approved these changes
Apr 6, 2020
|
Add a CHANGELOG entry please |
* changed changelog Fix kumahq#662
|
added changelog entry |
|
Thank you, merging. Just for future PRs. This is a feature not a fix. Fix is for fixing bugs. |
thanks and noted it. |
tharun208
added a commit
to tharun208/kuma
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Support
-min addition to--meshin kumactl #662Summary
added the shorthand name for mesh argument
SUMMARY_GOES_HERE
Full changelog
Issues resolved
Fix #662
Open Question:
We don't have a test for
inspect dataplanewith mesh name other than the default name. Is it worth adding?