ci(helm): no duplicates in helm chart package #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chart Releaser is always packaging dependencies specified in Chart.yaml file first. The archives with packaged dependencies lands inside "charts" directory (i.e. deployments/[...]/charts/[dependency_name]-[version].tgz). When building the final chart package, it includes inside, the content of the "charts" directory. When it finds an archive there, it flattens it and includes in the final package as well. It means if the chart have any dependencies, the final chart's archive will contain duplicated manifests. As Chart Releaser will automatically download the dependencies and then will archive them, we can safely remove the content of "charts" directory to mitigate the above issue. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
a team,
michaelbeaumont and
slonka
and removed request for
a team
slonka
previously approved these changes
Apr 12, 2023
|
Should we get rid of the explicit dependency and only rely on side packaged child helm chart. It seems like this double dependency is just recurring issues and troubles. |
Signed-off-by: Bart Smykla <[email protected]>
…ates-in-helm-chart-package
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
slonka
dismissed
their stale review
seems like I'm not an expert in this, I'll let other people review this
michaelbeaumont
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chart Releaser is always packaging dependencies specified in Chart.yaml file first. The archives with packaged dependencies lands inside "charts" directory (i.e. deployments/[...]/charts/[dependency_name]-[version].tgz). When building the final chart package, it includes inside, the content of the "charts" directory. When it finds an archive there, it flattens it and includes in the final package as well. It means if the chart have any dependencies, the final chart's archive will contain duplicated manifests. To mitigate this issue we are unarchiving (which would remove duplicates) and archiving the chart again.
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?