feat(gateway): auto host rewrite for gateway route #6328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to set auto_host_rewrite option for http gateway routes Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
a team,
slonka and
lukidzi
and removed request for
a team
…way-host-header-rewrite
Signed-off-by: Bart Smykla <[email protected]>
…way-host-header-rewrite
…way-host-header-rewrite
|
I see that Mike already reviewed this and I have like 10 "pending reviews" so I'm removing myself from this one. If you need my pair of eyes ping me here. |
lahabana
reviewed
Mar 30, 2023
lahabana
approved these changes
Mar 30, 2023
…way-host-header-rewrite
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
added |
Signed-off-by: Bart Smykla <[email protected]>
…way-host-header-rewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to set auto_host_rewrite option for http gateway routes
Closes: #5895
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? -- you don't> Changelog:entry here or add aci/label to run fewer/more tests?