feat(kumactl) provision Grafana with Kuma dashboards #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/install-metrics
branch
from
d4b5593 to
ac7d202
Compare
jakubdyszkiewicz
force-pushed
the
feature/install-metrics-dashboards
branch
from
e69de61 to
8a00fd4
Compare
jakubdyszkiewicz
changed the base branch from
feature/install-metrics
to
master
yskopets
reviewed
Feb 27, 2020
jakubdyszkiewicz
force-pushed
the
feature/install-metrics-dashboards
branch
2 times, most recently
from
2e52c05 to
d7343c9
Compare
yskopets
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provision Grafana with Kuma Dashboards.
Dashboards are stored in the same format as in online Grafana storage. This means we have to replace
${DS_PROMETHEUS}withPrometheus. This is placeholder so the user who imports the dashboard using ID can provide their own Prometheus datasource.To use dashboards in provision we need to explicitly provide name of the datasource.