Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-init): use distroless image #5945

Merged
merged 9 commits into from
Oct 22, 2024
Merged

chore(kuma-init): use distroless image #5945

merged 9 commits into from
Oct 22, 2024

Conversation

lobkovilya
Copy link
Contributor

Signed-off-by: Ilya Lobkov [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lobkovilya lobkovilya added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 7, 2023
@lahabana
Copy link
Contributor

lahabana commented Mar 6, 2023

@lobkovilya you know what this is blocking on?

@lobkovilya
Copy link
Contributor Author

Random legacy tests are failing, I didn't have time to look into them. I should be able to do it later this week

@lobkovilya lobkovilya closed this Apr 3, 2023
@slonka slonka reopened this Aug 1, 2023
@slonka slonka closed this Aug 1, 2023
@slonka slonka mentioned this pull request Oct 21, 2024
Closed
@slonka slonka reopened this Oct 21, 2024
@slonka @lobkovilya
chore(kuma-init): use distroless image
14d439f 
Signed-off-by: slonka <[email protected]>
Co-authored-by: Ilya Lobkov <[email protected]>
@slonka slonka force-pushed the chore/use-distroless-iptables-img branch from 0e9bb43 to 14d439f Compare October 21, 2024 13:09
@slonka
Copy link
Contributor

slonka commented Oct 21, 2024

I'm reviving this PR for #11786 - we might not need apt-mirror if we don't have apt
image

@slonka slonka force-pushed the chore/use-distroless-iptables-img branch from 98abb74 to 70668ef Compare October 21, 2024 15:00
@slonka slonka marked this pull request as ready for review October 21, 2024 18:48
@slonka slonka requested a review from a team as a code owner October 21, 2024 18:48
@slonka slonka requested review from slonka and Automaat and removed request for a team October 21, 2024 18:48
@slonka slonka requested a review from lahabana October 21, 2024 19:01
@slonka slonka merged commit d5963e7 into kumahq:master Oct 22, 2024
33 checks passed
@jijiechen jijiechen mentioned this pull request Oct 22, 2024
Closed
@slonka
Copy link
Contributor

slonka commented Oct 22, 2024

closed via #5945

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

backporting to release-2.7 with action

backporting to release-2.8 with action
backporting to release-2.9 with action

@github-actions GitHub Actions
Copy link
Contributor

backporting to release-2.6 with action

kumahq bot pushed a commit that referenced this pull request Nov 28, 2024
@lobkovilya @slonka @kumahq
chore(kuma-init): use distroless image (#5945)
097eb15 
Signed-off-by: Ilya Lobkov <[email protected]>

---------

Signed-off-by: slonka <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
Co-authored-by: slonka <[email protected]>
kumahq bot pushed a commit that referenced this pull request Nov 28, 2024
@lobkovilya @slonka @kumahq
chore(kuma-init): use distroless image (#5945)
7fc1d24 
Signed-off-by: Ilya Lobkov <[email protected]>

---------

Signed-off-by: slonka <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
Co-authored-by: slonka <[email protected]>
kumahq bot pushed a commit that referenced this pull request Nov 28, 2024
@lobkovilya @slonka @kumahq
chore(kuma-init): use distroless image (#5945)
1e30b67 
Signed-off-by: Ilya Lobkov <[email protected]>

---------

Signed-off-by: slonka <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
Co-authored-by: slonka <[email protected]>
This was referenced Nov 28, 2024
Closed
Closed
Closed
kumahq bot pushed a commit that referenced this pull request Nov 28, 2024
@lobkovilya @slonka @kumahq
chore(kuma-init): use distroless image (#5945)
7e6cc96 
Signed-off-by: Ilya Lobkov <[email protected]>

---------

Signed-off-by: slonka <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
Co-authored-by: slonka <[email protected]>
@kumahq kumahq bot mentioned this pull request Nov 28, 2024
Closed
This was referenced Nov 28, 2024
Merged
Merged
Merged
lukidzi added a commit that referenced this pull request Nov 28, 2024
@lukidzi
chore(images): pin ubuntu version (#12131)
c13b539 
## Motivation

The `kuma-init` image fails to build on Ubuntu versions newer than 22.
To avoid this issue, we plan to use an older runner image. This problem
does not occur on the `master` branch because we use a different base
image for `kuma-init`. Additionally, on `release-2.9`, we are already
using Ubuntu 22.04.

## Implementation information

Use ubuntu 22

## Supporting documentation


actions/runner-images#10636 (comment)
#5945
#11826

<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi added a commit that referenced this pull request Nov 28, 2024
@lukidzi
chore(images): pin ubuntu version (#12129)
244d5a6 
## Motivation

The `kuma-init` image fails to build on Ubuntu versions newer than 22.
To avoid this issue, we plan to use an older runner image. This problem
does not occur on the `master` branch because we use a different base
image for `kuma-init`. Additionally, on `release-2.9`, we are already
using Ubuntu 22.04.

## Implementation information

Use ubuntu 22

## Supporting documentation


actions/runner-images#10636 (comment)
#5945
#11826

<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

---------

Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi added a commit that referenced this pull request Nov 28, 2024
@lukidzi
chore(images): pin ubuntu version (#12130)
3e14297 
## Motivation

The `kuma-init` image fails to build on Ubuntu versions newer than 22.
To avoid this issue, we plan to use an older runner image. This problem
does not occur on the `master` branch because we use a different base
image for `kuma-init`. Additionally, on `release-2.9`, we are already
using Ubuntu 22.04.

## Implementation information

Use ubuntu 22

## Supporting documentation


actions/runner-images#10636 (comment)
#5945
#11826

<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

Signed-off-by: Lukasz Dziedziak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka left review comments

@jijiechen jijiechen jijiechen left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lahabana lahabana Awaiting requested review from lahabana

Assignees
No one assigned
Labels
backport ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lobkovilya @lahabana @slonka @jijiechen @jakubdyszkiewicz @lukidzi