Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): nack backoff #5894

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jan 31, 2023

Bringing nack backoff as we do in XDS.

I did not find a good way to test it aside from manual testing.

Fix #2164

Changelog: feat(kds): enable nack backoff

Checklist prior to review

  • Link to docs PR or issue -- no
  • Link to UI issue or PR -- no
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests -- no
  • E2E Tests -- no
  • Manual Universal Tests -- yes
  • Manual Kubernetes Tests -- no
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, slonka and Automaat and removed request for a team January 31, 2023 15:47
@jakubdyszkiewicz jakubdyszkiewicz merged commit 63627ee into kumahq:master Feb 1, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/kds-nack-backoff branch February 1, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NACK backoff for KDS
2 participants