feat(kuma-cp) support new format of Dataplane #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
approved these changes
Feb 14, 2020
| @@ -143,15 +170,15 @@ func ParseIP(text string) (string, error) { | |||
| } | |||
|
|
|||
| func (n *Dataplane_Networking) GetInboundInterface(service string) (*InboundInterface, error) { | |||
| for _, inbound := range n.Inbound { | |||
| ifaces, err := n.GetInboundInterfaces() | |||
There was a problem hiding this comment.
This comes at a price.
Can we avoid this ?
There was a problem hiding this comment.
Yeah, I decided to go for simplicity since I don't expect many inbounds (2? 5?), but ok - refactored so we convert it only when needed.
| @@ -210,13 +210,13 @@ var _ = Describe("snapshotGenerator", func() { | |||
| }, | |||
| Spec: mesh_proto.Dataplane{ | |||
| Networking: &mesh_proto.Dataplane_Networking{ | |||
| Inbound: []*mesh_proto.Dataplane_Networking_Inbound{{ | |||
| Interface: "192.168.0.3:3000:3000", | |||
| Address: "192.168.0.3", | |||
There was a problem hiding this comment.
Is it expected that we change input data but the outcome doesn't change ? Why to change input data then ?
There was a problem hiding this comment.
This is a test for Gateway Dataplane. I wanted to test if it works after the change.
jakubdyszkiewicz
force-pushed
the
feature/dp-new-format
branch
from
ebdfa45 to
08388fc
Compare
jakubdyszkiewicz
force-pushed
the
feature/gateway-metrics
branch
from
b195671 to
d0905db
Compare
jakubdyszkiewicz
changed the base branch from
feature/dp-new-format
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support the new format of the Dataplane across Kuma CP including scraping metrics from Gateway Dataplanes.