Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-cp: validate value of protocol tag on a Dataplane resource #576

Merged
merged 1 commit into from
Feb 13, 2020
Merged

kuma-cp: validate value of protocol tag on a Dataplane resource #576

merged 1 commit into from
Feb 13, 2020

Conversation

yskopets
Copy link
Contributor

Summary

  • validate value of protocol tag on a Dataplane resource

@yskopets yskopets requested review from a team and jakubdyszkiewicz February 12, 2020 12:50
@yskopets yskopets added this to the 0.4.0 milestone Feb 12, 2020
@yskopets yskopets force-pushed the feature/validate-protocol-tag branch from 59e2cf3 to bb1b4ba Compare February 12, 2020 12:52
jakubdyszkiewicz
jakubdyszkiewicz reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work on K8S?

We allow on K8S to specify whatever in protocol annotations, yet here we validate it to 2 values. Don't we validate the dataplane on K8S?

@yskopets yskopets force-pushed the feature/validate-protocol-tag branch from bb1b4ba to a32e46a Compare February 12, 2020 17:23
@yskopets yskopets changed the base branch from feature/support-protocol-annotation-on-k8s to master February 12, 2020 17:23
@yskopets
Copy link
Contributor Author

On k8s, Pod controller will translate <port>.service.mesh.io/protocol annotation into protocol tag "as is".

If the value specified in <port>.service.mesh.io/protocol annotation is not allowed, auto-generated Dataplane resource will be rejected by the validating web hook (with a message consistent between both k8s and universal environments).

So, Pod controller allows any values in <port>.service.mesh.io/protocol because those values will be validated by the validating web hook anyway.

jakubdyszkiewicz
jakubdyszkiewicz approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the explanation

@yskopets yskopets merged commit e16b908 into master Feb 13, 2020
@devadvocado devadvocado deleted the feature/validate-protocol-tag branch March 30, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yskopets @jakubdyszkiewicz