Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): support IPV6 in intercp #5492

Merged
merged 1 commit into from
Dec 13, 2022
Merged

feat(kuma-cp): support IPV6 in intercp #5492

merged 1 commit into from
Dec 13, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Dec 13, 2022 •
edited by lahabana
Loading

Signed-off-by: Jakub Dyszkiewicz [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(kuma-cp): intercp communication protocol

@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Dec 13, 2022
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and bartsmykla and removed request for a team December 13, 2022 13:11
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) December 13, 2022 13:19
@jakubdyszkiewicz jakubdyszkiewicz merged commit ce611b9 into kumahq:master Dec 13, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the test/fix-ipv6-intercp branch December 13, 2022 14:52
lahabana
lahabana reviewed Dec 14, 2022
View reviewed changes
pkg/intercp/catalog/catalog.go
@@ -15,7 +17,7 @@ type Instance struct {
}

func (i Instance) InterCpURL() string {
return fmt.Sprintf("grpcs://%s:%d", i.Address, i.InterCpPort)
return fmt.Sprintf("grpcs://%s", net.JoinHostPort(i.Address, strconv.Itoa(int(i.InterCpPort))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic :) I wonder if there's a linter for this we almost systematically do this mistake!

@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@lobkovilya lobkovilya lobkovilya approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubdyszkiewicz @lahabana @bartsmykla @lobkovilya