Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): forward envoy admin operations to proper instance #5466

Merged
merged 5 commits into from
Dec 19, 2022
Merged

fix(kuma-cp): forward envoy admin operations to proper instance #5466

merged 5 commits into from
Dec 19, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Dec 8, 2022 •
edited by slonka
Loading

waiting for #5445 to be merged

closes #5080

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz changed the title Fix/envoy admin forward fix(kuma-cp): forward envoy admin operations to proper instance Dec 13, 2022
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review December 13, 2022 10:10
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, slonka and Automaat and removed request for a team December 13, 2022 10:10
@jakubdyszkiewicz
fix: envoy admin forward
3144606 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
slonka
slonka reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, will probably need another round since this is quite big.

pkg/intercp/catalog/catalog.go Show resolved Hide resolved
pkg/intercp/catalog/catalog.go Show resolved Hide resolved
pkg/intercp/components.go Outdated Show resolved Hide resolved
pkg/intercp/client/pool_test.go Outdated Show resolved Hide resolved
pkg/intercp/envoyadmin/forwarding_kds_client.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
chore: review
40283aa 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz
chore: synced clocked for test
2521ac4 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz
chore: cancelfn
f562213 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@slonka
Copy link
Contributor

slonka commented Dec 16, 2022

Looks good, make sure to fix the test or check if it's not a flake.

@slonka
Copy link
Contributor

slonka commented Dec 16, 2022

Also, I've linked it to #5080 because this PR was not showing up on the board. If it's not the right ticket please remove it.

@jakubdyszkiewicz
chore: provide clock as arg
1459df5 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz merged commit e5b6a9d into kumahq:master Dec 19, 2022
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka approved these changes

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Envoy Admin operations with multizone and HA Global CP can fail
2 participants
@jakubdyszkiewicz @slonka