Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(policy): mesh health check validation #5415

Merged
merged 10 commits into from
Dec 6, 2022
Merged

feat(policy): mesh health check validation #5415

merged 10 commits into from
Dec 6, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Dec 2, 2022 •
edited by lahabana
Loading

closes #5380

Changelog: feat(policy): implement MeshHealthCheck policy

Checklist prior to review

  • Link to docs PR or issue -- not a final PR, will add docs with implem PR
  • Link to UI issue or PR -- not UI issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- yes
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS -- yes
  • Unit Tests --
  • E2E Tests -- no need yet
  • Manual Universal Tests -- no need yet
  • Manual Kubernetes Tests -- not need yet
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@slonka slonka changed the title feat(policy): mesh health check validation WIP feat(policy): mesh health check validation Dec 2, 2022
@slonka slonka marked this pull request as ready for review December 2, 2022 16:36
@slonka slonka requested a review from a team as a code owner December 2, 2022 16:36
@slonka slonka mentioned this pull request Dec 6, 2022
Closed
lukidzi
lukidzi approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@lukidzi lukidzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slonka slonka enabled auto-merge (squash) December 6, 2022 15:04
@slonka slonka merged commit 89fef9e into kumahq:master Dec 6, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New HealthCheck validation + api
2 participants
@slonka @lukidzi