Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(proto): fixed default serviceAddress and upgrade docs #5236

Merged
merged 6 commits into from
Nov 2, 2022
Merged

docs(proto): fixed default serviceAddress and upgrade docs #5236

merged 6 commits into from
Nov 2, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Oct 31, 2022

Split information about Universal and Kubernetes in UPGRADE docs, fixed default binding address in docs of Dataplane proto

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lukidzi lukidzi requested a review from a team as a code owner October 31, 2022 14:02
lahabana
lahabana reviewed Oct 31, 2022
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
api/mesh/v1alpha1/dataplane.proto Outdated Show resolved Hide resolved
michaelbeaumont
michaelbeaumont reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of nitpicking but I find the upgrade instructions unclear

UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
api/mesh/v1alpha1/dataplane.proto Outdated Show resolved Hide resolved
docs/generated/resources/proxy_dataplane.md Outdated Show resolved Hide resolved
@lukidzi
docs(kuma-dp): applied review changes
d4eef75 
Signed-off-by: Łukasz Dziedziak <[email protected]>
michaelbeaumont
michaelbeaumont reviewed Nov 2, 2022
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
michaelbeaumont
michaelbeaumont approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise ^^

@lukidzi
docs(kuma-dp): review changes
eaaf783 
Signed-off-by: Łukasz Dziedziak <[email protected]>
@lukidzi lukidzi merged commit b9c2064 into kumahq:master Nov 2, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@lobkovilya lobkovilya lobkovilya approved these changes

@mmorel-35 mmorel-35 mmorel-35 approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukidzi @lahabana @michaelbeaumont @mmorel-35 @lobkovilya