Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): customize location of kuma-init repository for ebpf cleanup #5230

Merged
merged 3 commits into from
Oct 31, 2022
Merged

fix(helm): customize location of kuma-init repository for ebpf cleanup #5230

merged 3 commits into from
Oct 31, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Oct 28, 2022 •
edited
Loading

Added passing of registry and repository to do not break other projects

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- fixes dependency
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • [X ] Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog feat(ebpf): transparent proxy with eBPF in init containers

@lukidzi lukidzi requested a review from a team as a code owner October 28, 2022 14:17
@lukidzi
fix(helm): fixed variable name
d5ae249 
Signed-off-by: Łukasz Dziedziak <[email protected]>
@lukidzi
fix(helm): removed unecessary sign
8b63283 
Signed-off-by: Łukasz Dziedziak <[email protected]>
@lukidzi lukidzi merged commit 6aad016 into master Oct 31, 2022
@lukidzi lukidzi deleted the fix/bpf-repo branch October 31, 2022 07:34
@lukidzi lukidzi changed the title fix(helm): now we provide value to repo of image fix(helm): customize location of kuma-init repository for ebpf cleanup Nov 3, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukidzi @lahabana