Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp): move attachments to inspect package #5202

Merged
merged 1 commit into from
Oct 25, 2022
Merged

chore(kuma-cp): move attachments to inspect package #5202

merged 1 commit into from
Oct 25, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Oct 24, 2022 •
edited by lukidzi
Loading

Discussed in #5189 (comment)

Move inspect stuff to inspect subpackage.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(inspect): implement rule-based view for new policies

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 24, 2022 13:26
michaelbeaumont
michaelbeaumont approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jakubdyszkiewicz jakubdyszkiewicz merged commit b569bbe into kumahq:master Oct 25, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/move-attachments-to-inspect branch October 25, 2022 07:55
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubdyszkiewicz @lahabana @michaelbeaumont