Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump github.com/Masterminds/sprig to 3.2.2 #5190

Merged
merged 1 commit into from
Oct 21, 2022
Merged

chore(deps): bump github.com/Masterminds/sprig to 3.2.2 #5190

merged 1 commit into from
Oct 21, 2022

Conversation

mmorel-35
Copy link
Contributor

Hi !

github.com/Masterminds/sprig is not a go 1.13 module,, this is migrating to github.com/Masterminds/sprig/v3 which is one.

Signed-off-by: Matthieu MOREL [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@mmorel-35 mmorel-35 marked this pull request as ready for review October 21, 2022 10:10
@mmorel-35 mmorel-35 requested a review from a team as a code owner October 21, 2022 10:10
lahabana
lahabana approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@lahabana lahabana enabled auto-merge (squash) October 21, 2022 10:32
@lahabana lahabana merged commit 826cd4c into kumahq:master Oct 21, 2022
@mmorel-35 mmorel-35 deleted the github.com/Masterminds/sprig/v3 branch October 21, 2022 10:35
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @lahabana